fix: deduplicate DOM query and add null guard in renderThemeSelectIcon#5896
Open
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Open
fix: deduplicate DOM query and add null guard in renderThemeSelectIcon#5896AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
AdityaM-IITH wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
@AdityaM-IITH pull updated master and solve these jest failures |
AdityaM-IITH
force-pushed
the
fix-theme-select-icon-null-guard
branch
from
1a63e85 to
4321803
Compare
Contributor
Author
|
Rebased on latest master (83c5c8d). All 117 test suites passing locally, including palette.test.js, logo.test.js, and logoconstants.test.js. The 3 previously failing tests were fixed upstream by the recent test file updates. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
renderThemeSelectIconmethod queries"themeSelectIcon"twiceusing two different methods (
document.getElementByIdanddocById),and accesses
.innerHTMLwithout verifying the element exists.Changes:
docById(consistent with codebase style)themeListvariableNo behavior change when element is present.